Help fopen fails

[Nekochan]

Hey guys,

I've noticed strange error, fopen returns NULL after some successful attempts, so I don't get any file loaded.
I've tried to zero it, but no luck.

Spoiler (Click to View)

memset(&filePtr, NULL, sizeof(FILE));

It's just

Code:

filePtr = fopen(str("%s/Debug/textures/%s", fs_path->string, filename), "rb");

'str' is

Code:

char* str( const char *msg, ... ) { va_list argptr; char text[1024]; va_start(argptr, msg); vsnprintf(text, sizeof(text), msg, argptr); va_end(argptr); return text; }

Here's what I got after some attempts

.. as you see first time it's fine, but for second time it returns '?' at the end. ( or 377/377/ and another gibrish stuff )

[Nukem]

Code:

char* str( const char *msg, ... ) { va_list argptr; char text[1024]; va_start(argptr, msg); vsnprintf(text, sizeof(text), msg, argptr); va_end(argptr); return text; }

Returning the temporary variable 'text' is baaaaaaaaad. Allocate a buffer, make 'text' static, or use a buffer in the caller's stack frame.

[kokole]

Code:

char* str( const char *msg, ... ) { va_list argptr; char text[1024]; va_start(argptr, msg); vsnprintf(text, sizeof(text), msg, argptr); va_end(argptr); return text; }

Returning the temporary variable 'text' is baaaaaaaaad. Allocate a buffer, make 'text' static, or use a buffer in the caller's stack frame.

Yeah that is no good, you're returning an array's pointer which has been created in the function's stack.

[Nekochan]

Oh thanks, I will try.

---

Oh yeah, now it works better.
I've made it 'static char text[1024];' and also created char *buf, now it returns right things.
Thanks.